Bug: party in "Disbanding" state would still recruit troops in a settlement

[dfr]

Conditions:

- a party undergoes the "Disbanding" period
- while being in a settlement

Result: the party would still recruit troops -- as per the overlay log displayed in small-font floaters over the city in the world map view.

This isn't logical, of course.

 

[VVL99]

This is not a mistake, it’s just that the group is given 24 hours, and during this time it has no task, so it can do whatever it wants.
I fixed this in my patch.

 

[dfr]

I would say it's conceptually a mistake -- the "DIsband" state suggests, well, disbanding -- which doesn't include recruiting.

I understand what you explain this is how it is implemented -- I just can't agree it's the right way, absent stronger arguments.

 

[VVL99]

Until recently, it was the case that the group would disband as soon as it reached the nearest settlement, but the developer added a waiting time, and now the group can enter into battle, defend the settlement, and replenish the squad within 24 hours, this was done intentionally.