In Progress [v1.1.3]Character Perk Effect description & code not match (Riding Shepherd)

Users who are viewing this thread

Version number
v1.1.3
Branch
Main
Modded/unmodded
No, I didn't use any mods.

Drio

Recruit
Summary:
Character Perk Riding.Shepherd, the description reduces the negative effect, and increases the speed of the party, but actually is slow down the party's speed.

v1.1.3

Code

namespace TaleWorlds.CampaignSystem.CharacterDevelopment
public class DefaultPerks
private void InitializeAll()


this._ridingShepherd.Initialize("{=I5LyCJzj}Shepherd", DefaultSkills.Riding, this.GetTierCost(7), this._ridingBreeder, "{=aiIPozp6}{VALUE}% party speed penalty from herding.", SkillEffect.PerkRole.PartyLeader, -0.5f, SkillEffect.EffectIncrementType.AddFactor, "{=YhZj58ut}{VALUE}% chance of producing tier 2 horses in villages bound to the governed settlement.", SkillEffect.PerkRole.Governor, 0.15f, SkillEffect.EffectIncrementType.AddFactor, TroopClassFlag.None, TroopClassFlag.None);

Effect
namespace TaleWorlds.CampaignSystem.GameComponents
public class DefaultPartySpeedCalculatingModel : PartySpeedModel
public override ExplainedNumber CalculateBaseSpeed(...)

{
float herdingModifier = this.GetHerdingModifier(num4, num3);
result.AddFactor(herdingModifier, DefaultPartySpeedCalculatingModel._textHerd);
if (mobileParty.HasPerk(DefaultPerks.Riding.Shepherd, false))
{
result.AddFactor(-herdingModifier * DefaultPerks.Riding.Shepherd.PrimaryBonus, DefaultPerks.Riding.Shepherd.Name);
}
}

Let herdingModifier is -0.8.
This code is -( -0.8 ) * -0.5 = -0.4, the party speed will be slow.

In v1.0.3,
This code is -( -0.8 ) * 0.01 * 50 = 0.4, the party speed is faster.
 
Hey, our team is aware of this issue and working on it. Thank you for your time and sorry for the inconvenience.
 
Patch v1.1.4
Fixes: "Fixed a bug that caused the riding perk 'Shepard' to reduce speed from herding instead of increasing it."
Our prayers have been answered
 
Back
Top Bottom