Resolved Unit skill effects not being applied in battle

Users who are viewing this thread

Summary:
Browsing your classes SandboxAgentStatCalculateModel and SandboxAgentApplyDamageModel in the sanbox.dll i found a bug that prevents non hero units from gaining the personal effects of skills.
At multiple points you use the method AddSkillBonusForCharacter(...) from SkillHelper in the Helpers namespace in the Campaignsystem.dll. At the start of this function you check if the units HeroObject is null and then return, which it always is for non hero units. This is done before applying personal effects so any non hero unit cannot get its skill effects. Surely, the check for heroObject == null should be performed after the check for personal effects.

Version:
This is present on both 1.4.1 and 1.4.2

Testing/reproducing this is easy, set a non hero unit stats to 5000 and notice the damage and swing speed effect of skills have no real effect for this unit. By switching the order of these checks they now get their expected effects.
 
Last edited:
Back
Top Bottom