Schools currently don't do anything

Users who are viewing this thread

kefka95

Squire
I already added this to the bugtracker, but I thought I would post it here as well to make sure I'm not losing my mind.  I was in the process of adding a "relation gained from school" tweak to TweakMB and noticed that this simple_triggers code doesn't seem to make any sense:

# Village upgrade triggers

# School
  (30 * 24,
  [(try_for_range, ":cur_village", villages_begin, villages_end),
      (party_slot_eq, ":cur_village", slot_town_lord, "trp_player"),
      (party_get_slot, ":cur_relation", ":cur_village", slot_center_player_relation),
      (val_add, ":cur_relation", 1),
      (val_min, ":cur_relation", 100),
      (party_set_slot, ":cur_village", slot_center_player_relation, ":cur_relation"),
    (try_end),
    ]),

That seems to be where the game adds the relation bonus for a school, but it never checks to see if the village actually has a school.  It just adds +1 relation to every village you own once a month.  I changed the relation bonus to +50 so it would be an obvious difference, and sure enough, I got +50 relation with every one of my villages (none of them have schools).

That said, this code has been in the game all the way back to vanilla M&B.  Surely this would have been caught before then?
 
Back
Top Bottom