EvilSquid
Recruit
OK this one is really minor - it only affects minstrels, specifically, when they tell you about feasts going on.
Surely I'm not the only one who noticed that they ALWAYS say "there's a feast at BLAH, but it's been going on for a few days and is about to end".
Well the following changes will mean that, occasionally, the minstrels may say that a feast has at least another day to go, or has only just begun - which can make finding feasts slightly less annoying (as a Lord anyway - kings can find details on their own kingdom's feasts easily enough).
This just requires changing the following code snippet in minstrel_courtship_locations (module_dialogs) - :
to this:
Caveat: I'm not 100% sure this is the best way to do this, since I suspect slot_faction_last_feast_start_time is supposed to be used for this - but there seems to be some confusion about whether this is supposed to be the start of the feast or the end of the feast.
On top of that, if I used slot_faction_last_feast_start_time it would quite often end up wrong, no matter how I did the calculations! I suspect that this slot is getting reset somewhere and this is messing with it.
At any rate, slot_faction_ai_current_state_started definitely points to when the AI state started - which happens to be equivalent to the feast start time as far as I can tell (when a feast is on that is). So, while I can't 100% say that the minstrels are now accurate, I can confirm that they now say three different things, whereas before we'd only get the same line.
Surely I'm not the only one who noticed that they ALWAYS say "there's a feast at BLAH, but it's been going on for a few days and is about to end".
Well the following changes will mean that, occasionally, the minstrels may say that a feast has at least another day to go, or has only just begun - which can make finding feasts slightly less annoying (as a Lord anyway - kings can find details on their own kingdom's feasts easily enough).
This just requires changing the following code snippet in minstrel_courtship_locations (module_dialogs) - :
插入代码块:
(store_current_hours, ":hour"),
(store_sub, ":hours_since_start", ":hour", 72),
(faction_get_slot, ":feast_time", ":kingdom", slot_faction_last_feast_start_time),
(val_add, ":hours_since_start", ":feast_time"),to this:
插入代码块:
(store_current_hours, ":hour"),
(faction_get_slot, ":feast_time", ":kingdom", slot_faction_ai_current_state_started),
(store_sub, ":hours_since_start", ":hour", ":feast_time"),Caveat: I'm not 100% sure this is the best way to do this, since I suspect slot_faction_last_feast_start_time is supposed to be used for this - but there seems to be some confusion about whether this is supposed to be the start of the feast or the end of the feast.
On top of that, if I used slot_faction_last_feast_start_time it would quite often end up wrong, no matter how I did the calculations! I suspect that this slot is getting reset somewhere and this is messing with it.
At any rate, slot_faction_ai_current_state_started definitely points to when the AI state started - which happens to be equivalent to the feast start time as far as I can tell (when a feast is on that is). So, while I can't 100% say that the minstrels are now accurate, I can confirm that they now say three different things, whereas before we'd only get the same line.
