Resolved Player Trait Bug with belief that its not fully broken...CODE INCLUDED

[Worldsprayer]

After using the debug console mod, I've found that the reason our traits go away from character creation is that the trait levels are being reset to zero when the trait xp is modified.
Example from several tests: A new character with "Honest" trait (honor level of 1 or more) is immediately reset to honor level 0 when successfully turning in a herd of animals.
Beliefs:
Because the trait is actively going from 1 to zero, that means "this.Hero.SetTraitLevel(trait, traitLevel);" in HeroTraitDeveloper.cs is triggering.
That means somewhere in BELOW in DefaultCharacterDevelopmentModel the int traitLevel is being set to a zero by default:

public override void GetTraitLevelForTraitXp(
      Hero hero,
      TraitObject trait,
      int xpValue,
      out int traitLevel,
      out int clampedTraitXp)
    {
      clampedTraitXp = xpValue;
      int num1 = trait.MinValue < -1 ? -6000 : (trait.MinValue == -1 ? -2500 : 0);
      int num2 = trait.MaxValue > 1 ? 6000 : (trait.MaxValue == 1 ? 2500 : 0);
      if (xpValue > num2)
        clampedTraitXp = num2;
      else if (xpValue < num1)
        clampedTraitXp = num1;
      traitLevel = clampedTraitXp <= -4000 ? -2 : (clampedTraitXp <= -1000 ? -1 : (clampedTraitXp < 1000 ? 0 : (clampedTraitXp < 4000 ? 1 : 2)));
      if (traitLevel < trait.MinValue)
      {
        traitLevel = trait.MinValue;
      }
      else
      {
        if (traitLevel <= trait.MaxValue)
          return;
        traitLevel = trait.MaxValue;
      }
    }

Honestly everything LOOKS right based on the 10 or so files I've compared. However, I think I might know what's going on.
During the initial character creation charactercreationcontent, this happens:

Hero.MainHero.SetTraitLevel(trait, Hero.MainHero.GetTraitLevel(trait) + traitLevelToAdd);

This is the code to apply to the character your level of traits. Note that it is ONLY modifying the character level, it is not changing anything about xp.

However, you can see in the following code from HreoTraitDeveloper that the xp being used to compare values is coming from an actual xp lookup for a trait.

public void AddTraitXp(TraitObject trait, int xpAmount)
    {
      xpAmount += this.GetPropertyValue((PropertyObject) trait);
      int traitLevel;
      int traitXp;
      Campaign.Current.Models.CharacterDevelopmentModel.GetTraitLevelForTraitXp(this.Hero, trait, xpAmount, out traitLevel, out traitXp);
      this.SetPropertyValue((PropertyObject) trait, traitXp);
      if (traitLevel == this.Hero.GetTraitLevel(trait))
        return;
      this.Hero.SetTraitLevel(trait, traitLevel);
    }

If during character creation the character is not being assigned actual XP...then first check during an addition or subtraction tells the game that you are ACTUALLY just adding to the original value: which is likely zero.

So, the brackets for Levels for traits are -2 to 2. Numerically for xp that -6k -> -4k (-2) ,-4k->-1k (-1), -1k -> 1k (0), (1k -> 4k(1), 4k->6k (2)
Now, remember that you are receiving 20,30, maybe 50 points of xp per event. that means you need to accomplish 20 quests (on average) succesfully. While it might not be the case, but I think it is very likely that people ARE leveling...but it's just not seen yet. Sadly there is no debug command to add trait xp, only set trait levels.

first post that led to this: https://forums.taleworlds.com/index...much-trouble-follow-on-post-connected.407336/

 

[Worldsprayer]

BUMP
After executing my first ever dll injection...I have indeed proved the bug.
Trait values ARE updating, but they're resetting to zero when they first get touched because the character creator set your level, but didn't actually give you any XP.
I changed a value from 30 honor to 6000 upon success of the herdsman mission and it shot me up to level 2 honor as i would expect.
The system is working...it just looks like it isn't because A) It's resetting values you see and B) it takes so long to actually advance the trait level.

 

[MArdA TaleWorlds]

I've been informed that this bug is fixed and will be sent to the live branch in the next updates. Thanks for reporting and sorry for any inconvenience!

 

[Worldsprayer]

Woohoo i was useful!!!