Lord "promotion" bug + fix (2.032)

[EvilSquid]

Currently, Lords are assigned a title/rank at game start, and whenever they change faction.

There are three ranks for each faction: one for Kings, one for Lords who only own a village, and one for Lords who own at least one fort or town.

The only thing currently missing is that Lords don't actually get "promoted" - i.e. if a Lord with only villages (or no fiefs at all) gets given a fort or town, their rank/title doesn't change.

To fix this simply requires adding the following snippet:

  (try_begin),
    (neq, ":lord_troop_id", "trp_player"),
    (call_script, "script_troop_set_title_according_to_faction", ":lord_troop_id", ":lord_troop_faction"),
  (end_try),

to the script give_center_to_lord in the town/fort section, e.g. after these lines works well:

    (try_begin),
        (this_or_next|party_slot_eq, ":center_no", slot_party_type, spt_town),
        (party_slot_eq, ":center_no", slot_party_type, spt_castle),
        (gt, ":lord_troop_id", -1),

If you're wondering why I explicitly don't do this for the player, it's because the troop_set_title_according_to_faction script, when called with the player's troop, replaces the player's name with "Player" and just adds the faction-specific title to the front of it (so I became "Konungr Player" whenever assigning a fief to myself as King - I suspect it'd do something similar with the other titles).

I'm guessing it was never intended for the player to receive a title - possibly due to potentially running out of characters for the player's name if the player chose a long one?

 

[kalarhan]

that is by design (WAI), or something that was decided to work this way back on VC RE beta/release. Lords get new titles when they change factions (faction was destroyed, you recruit a lord to yours, etc), but not promotion when they get land in the same faction.

maybe devs will revisit this idea and apply your suggestion

Cheers

 

[EvilSquid]

that is by design (WAI), or something that was decided to work this way back on VC RE beta/release. Lords get new titles when they change factions (faction was destroyed, you recruit a lord to yours, etc), but not promotion when they get land in the same faction.

maybe devs will revisit this idea and apply your suggestion

Cheers

So the original design decision was lords having titles set at the start only, so their "rank" effectively only ever changes, never actually increases? That makes some sense, but since titles are generally related to land, and since the game explicitly sets titles up based on land, IMO "promotion" should be a thing.

Especially since the same script is run whenever a lord changes faction - so in effect it is possible for a lord to get a "promotion", but only if they start as with one village or less, acquire at least one fort or town, then change factions (bringing the town/fort with them). Sure this isn't common, but can (and does) happen.

Irrespective of my thoughts on the matter, I'm happy for this thread to get moved to the modding section if this is indeed WAI.

 

[kalarhan]

So the original design decision was lords having titles set at the start only, so their "rank" effectively only ever changes, never actually increases?

increase or decrease. Lets use a medieval type for titles:

Lord: village
Baron: castle
Count: town
Duke: 2 towns
King: faction leader

What happens when Count Ragnar loses his town? He would have his named changed to Lord Ragnar. As territory changes hands often in wars, the naming of lords would change often and become harder to look for people in factions (yours or enemies). If the title was in the format "NAME TITLE" then that would be less of a issue.

The idea (original) was to update the base title when a lord changes faction. That way you won't have:

Ealdorman Ragnar, Tiarna Kalarhan, Warlord Squid, Jarl XXX -> in the same faction

so as you update titles to match the current faction, you get a more clean list (all Jarls, or all Warlords, etc) based on the faction culture.

VC at release had static titles.

 

[EvilSquid]

The idea (original) was to update the base title when a lord changes faction. That way you won't have:

Ealdorman Ragnar, Tiarna Kalarhan, Warlord Squid, Jarl XXX -> in the same faction

so as you update titles to match the current faction, you get a more clean list (all Jarls, or all Warlords, etc) based on the faction culture.

VC at release had static titles.

Yes this makes sense - things definitely make much more sense this way than with static titles. The only downside being, given that the naming convention is TITLE NAME, it requires knowing the title of the person if you're looking for them in the name list. Additionally, as a side-effect, it appears that this also invalidates the rivalry hyperlinks on a lord's notes page (although most of the time I've seen ALL of a Lord's rivalries lose their hyperlink status - sending someone to spy on their kingdom tends to update that though, and it usually doesn't take too long to figure out where they went).

So the original design decision was lords having titles set at the start only, so their "rank" effectively only ever changes, never actually increases?

increase or decrease. Lets use a medieval type for titles:

Good point! I had completely overlooked the case of ranks actually decreasing, as I'm pretty sure that function isn't called when lords lose a fief, only when they gain one...

Edit: OK it appears that give_center_to_lord is called whenever a fief changes hands, so just make sure to check/adjust the old lord in case he got demoted:

(try_begin),
        (eq, ":faction_leader", ":old_lord_troop_id"),
        (call_script, "script_add_log_entry", logent_liege_grants_fief_to_vassal, ":faction_leader", ":center_no", ":lord_troop_id", ":lord_troop_faction"),
        (troop_set_slot, ":lord_troop_id", slot_troop_promised_fief, 0),
      #SQUID changes begin
      (else_try),
	# Old lord was not a faction leader - meaning it was taken from him, so check for updates to his rank in case of demotion
	(store_troop_faction, ":old_troop_faction", ":old_lord_troop_id"),
	(call_script, "script_troop_set_title_according_to_faction", ":old_lord_troop_id", ":old_troop_faction"),
      #SQUID changes end
      (try_end),

Not tested yet but should work...

 

[kalarhan]

if you're looking for them in the name list

off-topic comment: I use a simple filtered system on my mods. When you click on a faction (example), it will only display the lords and centers of that faction (if you visit the other Notes pages).

Open characters page: 100 names
Open factions page, click on a faction, apply filter
Open characters page again: 10 names
Open centers: 3 names
Close notes pages, reset filter

a example of a workflow with it



off-topic again:
  about the titles + naming convention: I personally use a different system (for troops, lords, etc), as to make reading the names (and understand things like level, tier, vassal power, etc) easier.


off-topic again:
  order list: Warband lacks operations (functions) to manipulate strings, like ordering names when you navigate the Notes page, as far as modsys (what we modders/third party devs can use). Something we hope Bannerlord won't repeat hehe.

 

[EvilSquid]

if you're looking for them in the name list

off-topic comment: I use a simple filtered system on my mods. When you click on a faction (example), it will only display the lords and centers of that faction (if you visit the other Notes pages).
...

Cool, yeah I've noticed that other mods have many QOL improvements over both the base game and VC. I generally navigate from the Notes Faction page to find associated fiefs and/or lords, but there are definitely times when I thought that the ordering could be better, or presented better.

It's mainly annoying when I want to check my relation with a lord that is waiting to join my faction (or get rejected) - these lords change their title but they don't show up on your faction page because they technically haven't joined yet. Although funnily enough, kingdom ladies will count them as part of your faction for the purposes of giving them gifts.