I noticed the loot wagons bug out once you get a chancellor. Checking the source, I found that dplmc_spt_gift_caravan and spt_player_loot_wagon are both set to the same thing: 21. This makes the diplomacy code take over for loot wagons as soon as you have a chancellor, which deletes the wagon when it hits a center and acts like it was a gift caravan.
I also noticed that the code for calculating rent for castles has:
(party_slot_eq, ":center_no", slot_party_type, spt_castle),
(assign, ":cur_rents", -250),
Is that assign supposed to be there? What that effectively does is completely erase all the calculations for castle rents and just sets it to -250 if it's a castle, then having a blacksmith adds 50 making it 200. The actual rent ingame on my castle seemed to perpetually be 200, I didn't bother checking how the code got there but I guess it must be taking the -200 as a positive (which meant me building the blacksmith probably cut my income, lol).
I also noticed that the code for calculating rent for castles has:
(party_slot_eq, ":center_no", slot_party_type, spt_castle),
(assign, ":cur_rents", -250),
Is that assign supposed to be there? What that effectively does is completely erase all the calculations for castle rents and just sets it to -250 if it's a castle, then having a blacksmith adds 50 making it 200. The actual rent ingame on my castle seemed to perpetually be 200, I didn't bother checking how the code got there but I guess it must be taking the -200 as a positive (which meant me building the blacksmith probably cut my income, lol).