Resolved General Added banner colors do not work if added ColorIds are not consecutive/sequential

[xucan]

Summary: When following the steps outlined here for adding new banner colors, there's no mention of any requirements on the new colorIds other than that they must be unique. However, there is a problem when the ColorId of a new color does not immediately follow the last existing ColorId. For example, if the default colorIds are 1,2,3,4,5 then the new color MUST have the ColorId 6, otherwise it doesn't work. When the color gets selected in the banner editor, the clothing color updates properly but the banner and shield color sets to the default color. Either this is a bug or a note should be added to the docs clarifying the requirements for the ColorId
How to Reproduce: As described in the docs for adding colors, add a `banner_icons.xml` file to your mod with something like:

<?xml version="1.0" encoding="utf-8"?>
<base xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" type="string">
  <BannerIconData>
    <BannerColors>
      <Color id="1000" hex="0xffDC143C" player_can_choose_for_background="true" />
      <Color id="1001" hex="0xff000080" player_can_choose_for_background="true" />
      <Color id="1002" hex="0xffBDB76B" player_can_choose_for_background="true" />
    </BannerColors>
  </BannerIconData>
</base>

Start the game, get into the banner editor, select one of the new colors.
Media (Screenshots & Video):

 

[MArdA TaleWorlds]

Forwarded to the QA team for further investigation. We will reach out again if we need more information. Thanks for reporting and sorry for any inconvenience!

 

[MArdA TaleWorlds]

I've been informed that this bug is fixed and the fix will be sent to the game with future patches. Thanks for reporting and sorry for any inconvenience!