Are you using the stats from 1.2 or 1.3 (beta)?
Here's the skills taken right from SandboxCore\ModuleData\spnpccharacters.xml of 1.3:
| Veteran Warrior | Shock Troop |
Athletics | 130 | 125 |
Riding | 60 | 45 |
OneHanded | 130 | 140 |
TwoHanded | 80 | 60 |
Polearm | 80 | 140 |
Bow | 60 | 75 |
Crossbow | 20 | 15 |
Throwing | 130 | 30 |
Veteran Warrior uses Athletics, OneHanded, and Throwing due to gear (no horse, 1h axe, shield, javelin).
Shock Troop uses Athletics, OneHanded, and Polearm due to gear (no horse, 1h sword, shield, spear).
As you can see for the stats that matter, the two are largely equal with an edge to shock troop in all but athletics. Use the Veteran Warrior when you want infantry with a bit of pre-melee range attack. Use Shock Troop when defending from cavalry is important.