Author Topic: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)  (Read 64173 times)

0 Members and 1 Guest are viewing this topic.

kalarhan

  • Python Saint
  • Count
  • *
  • Use Q&A thread, not a PM :)
    • View Profile
  • Faction: Neutral
  • WBNWVCWF&S
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #195 on: January 18, 2018, 04:54:44 PM »
But it doesn't reference the original faction.

that scripts calculates how much money the lord has, to decide how many soldiers he can hire. The actual selection of troops is done on script_cf_reinforce_party, as you can see by the line "(call_script, "script_cf_reinforce_party", ...)

Alex Kit

  • Veteran
  • *
    • View Profile
  • Faction: Neutral
  • WB
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #196 on: January 18, 2018, 05:05:40 PM »
Thank you!!

I was mislead by this comment
# Adds reinforcement to party according to its type and faction
# Called from several places, simple_triggers for centers, script_hire_men_to_kingdom_hero_party for hero parties

Anyway, this is this script

Code: [Select]
script_cf_reinforce_party
  # Input: arg1 = party_no,
  # Output: none
  # Adds reinforcement to party according to its type and faction
  # Called from several places, simple_triggers for centers, script_hire_men_to_kingdom_hero_party for hero parties
  ("cf_reinforce_party",
    [
      (store_script_param_1, ":party_no"),
     
      (store_faction_of_party, ":party_faction", ":party_no"),
      (party_get_slot, ":party_type",":party_no", slot_party_type),
     
      #Rebellion changes begin:
      (try_begin),
        (eq, ":party_type", spt_kingdom_hero_party),
        (party_stack_get_troop_id, ":leader", ":party_no"),
        (troop_get_slot, ":party_faction",  ":leader", slot_troop_original_faction),
      (try_end),
      #Rebellion changes end
     
      (try_begin),
        (eq, ":party_no", "p_main_party"),
        (try_begin),
          (is_between, "$players_kingdom", npc_kingdoms_begin, npc_kingdoms_end),
          (assign, ":party_faction", "$players_kingdom"),
        (else_try),
          (assign, ":party_faction", "fac_player_supporters_faction"),
        (try_end),
       
      (else_try),
        (eq, ":party_faction", "fac_player_supporters_faction"),
        (is_between, ":party_no", walled_centers_begin, walled_centers_end),
        (party_get_slot, ":town_lord", ":party_no", slot_town_lord),
        (try_begin),
          (gt, ":town_lord", 0),
          (troop_get_slot, ":party_faction", ":town_lord", slot_troop_original_faction),
        (else_try),
          (party_get_slot, ":party_faction", ":party_no", slot_center_original_faction),
        (try_end),
      (try_end),
     
      (faction_get_slot, ":party_template_a", ":party_faction", slot_faction_reinforcements_a),
      (faction_get_slot, ":party_template_b", ":party_faction", slot_faction_reinforcements_b),
      (faction_get_slot, ":party_template_c", ":party_faction", slot_faction_reinforcements_c),
     
      (assign, ":party_template", 0),
      (store_random_in_range, ":rand", 0, 100),
      (try_begin),
        (this_or_next|eq, ":party_type", spt_town),
        (eq, ":party_type", spt_castle),  #CASTLE OR TOWN
        (try_begin),
          (lt, ":rand", 65),
          (assign, ":party_template", ":party_template_a"),
        (else_try),
          (assign, ":party_template", ":party_template_b"),
        (try_end),
      (else_try),
        (this_or_next|eq, ":party_no", "p_main_party"),
        (eq, ":party_type", spt_kingdom_hero_party),
        (try_begin),
          (lt, ":rand", 55),
          (assign, ":party_template", ":party_template_a"),
        (else_try),
          (lt, ":rand", 75),
          (assign, ":party_template", ":party_template_b"),
        (else_try),
          (assign, ":party_template", ":party_template_c"),
        (try_end),
      (try_end),
     
      (try_begin),
        (gt, ":party_template", 0),
        (party_add_template, ":party_no", ":party_template"),
      (try_end),
  ]),

As I noted earlier, excluding Rebellion, it only references to troop_original_faction here:
Code: [Select]
          (troop_get_slot, ":party_faction", ":town_lord", slot_troop_original_faction),

Is this the line that needs to be changed? What should I better change it to?

kalarhan

  • Python Saint
  • Count
  • *
  • Use Q&A thread, not a PM :)
    • View Profile
  • Faction: Neutral
  • WBNWVCWF&S
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #197 on: January 18, 2018, 05:12:44 PM »
Is this the line that needs to be changed? What should I better change it to?

one of them.

Code: [Select]
      #Rebellion changes begin:
      (try_begin),
        (eq, ":party_type", spt_kingdom_hero_party),
        (party_stack_get_troop_id, ":leader", ":party_no"),
        (troop_get_slot, ":party_faction",  ":leader", slot_troop_original_faction),
      (try_end),
      #Rebellion changes end
disable/remove this and also the rebellion system (there is a tweak for that).

the second party controls garrison troops (if you want towns/castles to have faction troops). Remove/disable it.

There may be other parts to change in the code (testing is your friend). You can check the [modding Q&A thread] https://forums.taleworlds.com/index.php/topic,347990.0.html for further help, as it is not about the tool itself.

Happy modding!

Tingyun

  • Knight at Arms
  • *
  • Hooded Horse Inc., an Indie Game Studio in Texas
    • Steam - hoodedhorse
    • Twitter - @HoodedHorseInc
    • View Profile
    • Hooded Horse
  • Faction: Neutral
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #198 on: January 28, 2018, 11:05:20 PM »
Thanks again for creating this wonderful tool!

A couple of mistakes found in the module files included with the tweaks tool 1.2:

In module_constants.py under #para negativos equipamiento chief habilidades

Tweaks tool has

desnudos_end = "itm_picts_hoodtunic_11"

2.036 has the correct term

desnudos_end = "itm_picts_hoodtunic_03"

This changes what equipment gets modifiers.

Next, in module_scripts, several of the terms for merchant gold deviate from default values because they are missing + and - amounts, so that even if the player does not tweak the value they still end up with substantially different merchant gold rules than Vanilla VC. So for example, in a couple of places:

Tweaks tool has:

(store_random_in_range,":new_gold",TWEAK_MERCHANT_MIN_CASH,TWEAK_MERCHANT_MAX_CASH),
       

2.036 has:
        (store_random_in_range, ":new_gold", 1000,2500),

For example the second term should have a -1500 modifier in the tweaks tool to maintain vanilla behavior with default values.


Thanks again for maintaining this great tool!




Tingyun

  • Knight at Arms
  • *
  • Hooded Horse Inc., an Indie Game Studio in Texas
    • Steam - hoodedhorse
    • Twitter - @HoodedHorseInc
    • View Profile
    • Hooded Horse
  • Faction: Neutral
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #199 on: January 28, 2018, 11:15:34 PM »
Seperating from the bug report some questions about differences that are not errors. I am sure the tweaks tool is right on them, just I was curious about the reason for the difference. Could you explain so I could learn a bit more?

Module_scripts.py, the Tweaks tool has this at the very beginning:

("game_check_party_sees_party", []),
  ("game_missile_launch", []),

But Vanilla VC module files lack this. I am curious what it does?

Then tweaks has this line in 2 places in module_scripts, after the script to calculate morale is used:
(assign, reg8, reg0),

2.036 instead has this line:
(assign, reg8, 50),

I imagine it is because tweaks tool lets the user mod default morale, but since the script that calculates morale also modifies it before assigning it to reg0, I can't figure out why Vanilla VC doesn't also use the reg0 value here.

I understand these 2 aren't problems with the tweaks tool, just curious to learn more about the reason for the difference.

kalarhan

  • Python Saint
  • Count
  • *
  • Use Q&A thread, not a PM :)
    • View Profile
  • Faction: Neutral
  • WBNWVCWF&S
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #200 on: January 29, 2018, 01:54:16 AM »
First is just to clean up rgl_log.txt (so it won't complain about not finding such scripts). They are optional and not used on the DLC.

Second is related to changes in morale for tweaks. Vanilla tends to force morale to 50 on a more agressive way. Tweak lets you regulate the base target (average)

Tingyun

  • Knight at Arms
  • *
  • Hooded Horse Inc., an Indie Game Studio in Texas
    • Steam - hoodedhorse
    • Twitter - @HoodedHorseInc
    • View Profile
    • Hooded Horse
  • Faction: Neutral
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #201 on: January 29, 2018, 02:32:27 AM »
Thanks Kalarhan, that's really helpful to know regarding that second group of differences. :)

« Last Edit: January 29, 2018, 06:22:03 PM by Tingyun »

kalarhan

  • Python Saint
  • Count
  • *
  • Use Q&A thread, not a PM :)
    • View Profile
  • Faction: Neutral
  • WBNWVCWF&S
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #202 on: January 29, 2018, 12:30:43 PM »
Remember that this tool is not a submod or a unofficial patch or a fork to the game. It simple takes what is there and adds options to players to choose minor tweaks or even a quicker path to starting to mod the game themselves.

You won't find bug fixes here by design.

Tingyun

  • Knight at Arms
  • *
  • Hooded Horse Inc., an Indie Game Studio in Texas
    • Steam - hoodedhorse
    • Twitter - @HoodedHorseInc
    • View Profile
    • Hooded Horse
  • Faction: Neutral
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #203 on: January 29, 2018, 04:43:08 PM »
You won't find bug fixes here by design.

We are talking about bugs created by the Tweaks Tool itself, things that work fine in Vanilla Viking Conquest 2.036 but get messed up if the Tweaks Tool is used.


The 2 earlier bug reports I made in the first reply are both instances where the VC tweaks tool module files differ from the official 2.036 files in a way not justified by any intended tweaks, and introduces bugs not present in vanilla 2.036 Viking Conquest.

For the first one, the tweaks tool has: desnudos_end = "itm_picts_hoodtunic_11"

In the place that vanillla 2.036 has the correct term: desnudos_end = "itm_picts_hoodtunic_03"

That means the Tweaks Tool has a bug with equipment modifiers. I think what happened is this: In a recent patch, the developers probably updated module_constants.py to fix a bug, but the change was not properly copied over to the tweaks tool, so the tweaks tool retains the earlier bug. Since the tweaks tool is intended to reflect 2.036, it should have all the same fixes the VC devs made to it.

And the merchant gold tweak having incorrect calculations is not a bug that only affects those who tweak--instead it means someone who leaves that tweak off will unintentionally and unknowingly receive a different experience than vanilla. This is because in some places where the tweaks tools has TWEAK_MERCHANT_MAX_CASH, the vanilla VC files have 4000, and in other places they have 2500. That means in some places the Tweaks Tool is missing a -1500 term--it has it in some places, it just looks like it was forgotten to include that term in some other places where it is needed.

Since tweaks off should mean vanilla behavior, that is an bug specifically with the tool, and the fact the correction was done in some but not other places makes clear it was just an error.

In other words, both bugs are bugs with the tweaks tool specifically, areas where the tweaks file differs from the unmodded vanilla VC 2.036 module files in a way that creates differences from the latest version of vanilla without a tweak activated, or the Tweaks Tool introduces a bug not present in 2.036.
« Last Edit: January 29, 2018, 06:29:19 PM by Tingyun »

kalarhan

  • Python Saint
  • Count
  • *
  • Use Q&A thread, not a PM :)
    • View Profile
  • Faction: Neutral
  • WBNWVCWF&S
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #204 on: January 29, 2018, 06:29:10 PM »
Is tweaks tool free from bugs? Of course not, as no software ever created is bug free. Feel free to report any doubt, and they will be analysed if we ever get a new update.

You can agree/disagree with any change introduced here. You are (as any player) encouraged to further modify it to your heart's content.

To understand the history you would need to go back to 2014 and follow 2 years of discussions (back when the game was new and changing, and the community as actually big).

However to change the nature of any of them you would need to travel back in time and join the conversations from a few years ago, some of each can be found on the Tweaks thread.

It is not the purpose of this thread to discuss them (you can do that in the Tweaks thread), neither explain the tech side (q&a thread), just help with any installations issues.

Cheers

lewisjac

  • Recruit
  • *
    • View Profile
  • Faction: Nord
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #205 on: February 01, 2018, 03:53:59 PM »
Hey guys my module wont show in my selection (the folder is named VC_Tweaks_Tool_2.1) and I'm not seeing it. Every step was completed and my cmd window had no errors.

kalarhan

  • Python Saint
  • Count
  • *
  • Use Q&A thread, not a PM :)
    • View Profile
  • Faction: Neutral
  • WBNWVCWF&S
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #206 on: February 01, 2018, 04:06:46 PM »
Hey guys my module wont show in my selection (the folder is named VC_Tweaks_Tool_2.1) and I'm not seeing it. Every step was completed and my cmd window had no errors.

check if your folder is on the right position: [game folder]/Modules/[your mod] and if you just need to scroll down the list of modules (on the game launcher).

lewisjac

  • Recruit
  • *
    • View Profile
  • Faction: Nord
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #207 on: February 01, 2018, 04:13:27 PM »
yeah it is in my modules folder of my Mount and Blade Warband folder (programfiles86) and I scrolled through the list and I can't seem to see it

lewisjac

  • Recruit
  • *
    • View Profile
  • Faction: Nord
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #208 on: February 01, 2018, 04:17:41 PM »
I got it, it was supposed to be in program files not 86, thank you for the reply!

kalarhan

  • Python Saint
  • Count
  • *
  • Use Q&A thread, not a PM :)
    • View Profile
  • Faction: Neutral
  • WBNWVCWF&S
Re: [TWEAKS] VC Tweaks Tool: +80 tweaks the easy way! (released/1.2)
« Reply #209 on: February 01, 2018, 04:27:55 PM »
thank you for the reply!

no problem, have fun raiding!