Zoom-in Function

[HokieBT]

The way I stopped speeder bikes (horses) from moving in my mod when not ridden was to run a trigger to set the animation to an unused one every second... So maybe we have to do something similar when the player zooms in? That same trigger could potentially also change the camera angle to the player look or something...

[WilliamBerne]

Just tested move the cam without (mission_cam_set_mode,1), it didn't help. the cam was moved to the certain position in 1 secend, then it was draged back to the player very quickly.
maybe try (mission_cam_set_mode,2),  or 3 later. but I doubt if it will work.

I think we can simply tell the player: don't use this function before you fully stop, or you may run into enemies.
Sniperscope won't go well I believe, but a unmovable binoculars is acceptable.

[jik]

Can we override the movement?  Something similar to this:

  (ti_tab_pressed, 0, 0, [],
   [(try_begin),
      (eq, "$g_mt_mode", abm_visit),
      (set_trigger_result, 1),
    (else_try),
      (question_box,"str_give_up_fight"),
    (try_end),
    ]),

[HokieBT]

ok, I played around with the concept of binoculars and am pretty happy with how it is working so far.  If you have itm_binocular in your inventory then the B key changes you view between a 0-4x magnification.  The player and/or horse they are ridding will stop moving while you are zoomed in.  You can also use your mouse to move the binoculars while zoomed.  It could use a presentation overlay (no clue how to add that), and I may have some redundant code so let me know if you guys can improve it any further...

create itm_binocular in module_items.py

["binocular","Macro Binoculars", [("laser_scope",0)], itp_merchandise|itp_type_goods, 0,5000,weight(5)|abundance(40),imodbits_none],

add this to the top of module_mission_templates.py

from module_animations import *

copy this into the top part of module_mission_templates.py with the other common_ code

(click to show/hide)

Code: [Select]

#--------------------------------------------------------------------------------------------------------------------------------------------------
#SW - zoom in/out code by jik and WilliamBerne - http://forums.taleworlds.net/index.php/topic,68192.0.html - modified further by HokieBT
common_use_binocular_1 = (0, 0, 0, [
(key_clicked, key_b)
],
[
(get_player_agent_no, ":player_agent"),
(agent_is_alive, ":player_agent"),
#(troop_get_inventory_capacity, ":inv_cap", "trp_player"),
(troop_get_inventory_capacity, ":inv_cap", "$g_player_troop"), #since custom commander is integrated
(assign, ":binocular_slot", -1),
(try_for_range, ":slot_no", 0, ":inv_cap"),
#(troop_get_inventory_slot,":item_id","trp_player",":slot_no"),
(troop_get_inventory_slot,":item_id","$g_player_troop",":slot_no"), #since custom commander is integrated
#check for binoculars
(try_begin),
(eq, ":item_id", "itm_binocular"),
(assign, ":binocular_slot", ":slot_no"),
(try_end),
(try_end),

(try_begin),
(eq, ":binocular_slot", -1),
(display_message, "@You don't have any Binoculars in your inventory!"),
(else_try),

(try_begin),
(le, "$binocular_magnification", 0), #incase this variable isn't set yet
(assign, "$binocular_magnification", 1000),
(display_message, "@Binocular Zoom is 1x"),
(else_try),
(eq, "$binocular_magnification", 1000),
(assign, "$binocular_magnification", 2000),
(display_message, "@Binocular Zoom is 2x"),
(else_try),
(eq, "$binocular_magnification", 2000),
(assign, "$binocular_magnification", 3000),
(display_message, "@Binocular Zoom is 3x"),
(else_try),
(eq, "$binocular_magnification", 3000),
(assign, "$binocular_magnification", 4000),
(display_message, "@Binocular Zoom is 4x"),
(else_try),
(eq, "$binocular_magnification", 4000),
(assign, "$binocular_magnification", 0),
(display_message, "@Binocular Zoom is off"),
(try_end),
#change the zoom
(try_begin),
(le, "$binocular_magnification", 0),
(mission_cam_clear_target_agent),
(mission_cam_set_mode,0),
(mission_cam_set_target_agent, ":player_agent", 1),
(else_try),
(mission_cam_clear_target_agent),
(assign,":height",0),
#get where the player is looking
(agent_get_look_position, pos1, ":player_agent"),
(position_move_y,pos1,"$binocular_magnification"),
(position_get_z,":height",pos1),
(try_begin),
(lt,":height",50),
(position_move_z,pos1,200),
(try_end),
(mission_cam_set_mode,1),
(mission_cam_animate_to_position, pos1, 100, 0), #the speed of the zoom-in
(try_end),
(try_end),
])

common_use_binocular_2 = (
  0.1, 0, 0,
   [
(try_begin),
(gt, "$binocular_magnification", 0),
(get_player_agent_no, ":player_agent"),
(agent_is_alive, ":player_agent"),
#(agent_set_animation, ":player_agent", "anim_unused_human_anim_1"), #so the player doesn't move, must include module_animations at the top of the python file
(agent_set_animation, ":player_agent", "anim_defend_fist"), #so the player looks more like they are holding binoculars

(try_for_agents, ":cur_agent"),
(agent_is_alive, ":cur_agent"), #so we don't try dead agents
(neg|agent_is_human,":cur_agent"), #agent is a horse
(agent_get_rider,":cur_rider", ":cur_agent"),
(eq, ":cur_rider", ":player_agent"), #rider of this horse is the player
(agent_set_animation, ":cur_agent", "anim_unused_horse_anim_1"), #so the horse doesn't move, must include module_animations at the top of the python file
(try_end),

#fix the camera to follow the mouse movement
#reset the camera (not sure all of these steps are necessary?)
(mission_cam_clear_target_agent),
(mission_cam_set_mode,0),
(mission_cam_set_target_agent, ":player_agent", 1),
#zoom in the camera (removed the height check so the camera wouldn't jump on the z-axis as the player moved the mouse around)
(mission_cam_clear_target_agent),
(agent_get_look_position, pos1, ":player_agent"),
(position_move_y,pos1,"$binocular_magnification"),
(mission_cam_set_mode,1),
(mission_cam_animate_to_position, pos1, 1, 0), #the speed of the zoom-in (really fast for the mouse movement camera, zero doesn't work)

(try_end),
    ],
   [
    ])
#---------------------------------------------------------------------------------------------------------------------------------------------------


add this to any mission template you want to be able to use them

      common_use_binocular_1,
      common_use_binocular_2,

[bjorne.]

WoW HokieBT are you going to use this in your mod?

[jik]

can you still do a weapon attack?  Have you tried shooting while in the zoom in mode?  If so, this can easily translate into a scope.

[HokieBT]

yeah, I'm going to use this in my mod.   I was working on this last night, so do remember that I was able to fire, but don't remember if it shot in the center of the screen.  I think the regular crosshairs didn't move (which would be fine for a scope) but my guess would be that the angle of the aim would be off.  I think we'd probably need to move the camera position to start from the players hand, since right now I think its from the player's face, but that may change because of that :height check in there?  We'd probably also have to check if riding a horse made a difference, etc....  Right now the code checks if itm_binocular is in your inventory, but it could easily be modified to check if one of your equipped items is a gun with a scope, etc.   Anyway, this is about the limit on my coding skill, and I don't understand anything with all these camera commands (I just cut-n-pasted what you guys had), but I bet this could be improved to make a decent binoculars and/or scope.

edit:  I also set the animation to anim_defend_fist to stop the player from moving, but if they are mounted then they move to the ground.  So I might want to reverse the code to first check if the player is riding a horse and if they are set it to a different animation, otherwise use the defend_fist one....  might also be cool if we could run a command to sheath your weapon if you are using the binoculars, since right now I hold a sword up to my head when I do the anim_defend_fist. 

I'd also like to eventually add a mesh overlay, something like this would look awesome for my star wars mod.  hehe

[HokieBT]

figured I bump this if anybody is interested.  People can probably improve my code, but its pretty neat.  The aiming crosshairs are still visible if you have a gun equipped and the sniper scope concept doesn't seem to work great, but binoculars are very cool.    We may be able to get a sniper working with a little work....

       

[jik]

Nice!  When's the next release of the mod?

[HokieBT]

I'd guess the next release will hopefully be this week or next one.

[rorschach82]

hmm.. did you guys find the script to move the cameras and stuff??
is it possible to zoom out the camera instead of zooming in??

i was planning on using an overlay mesh like those scope designs in order to enhance the player GUI
and i would like to be able to fight in a real 3rd-person POV rather than that over-the-shoulder view..

something like this:

[HokieBT]

yeah, I think that should be possible.   We integrated a death camera when you can watch the battle from above one of your troops perspectives, so you you control the position of the camera and a few other things.   These type of posts might get you started.

http://forums.taleworlds.net/index.php/topic,59637.0.html
http://forums.taleworlds.net/index.php/topic,61929.0.html

[rorschach82]

yeah, I think that should be possible.   We integrated a death camera when you can watch the battle from above one of your troops perspectives, so you you control the position of the camera and a few other things.   These type of posts might get you started.

http://forums.taleworlds.net/index.php/topic,59637.0.html
http://forums.taleworlds.net/index.php/topic,61929.0.html

thanks HokieBT. browsing in those threads right now..

btw, your starwars mod is great. i just played it sometime ago.