[WB][Script] Weapon breaking trigger

[Gaunt]

Module Mission Templates,

You can add it before

multiplayer_server_check_belfry_movement

And then add

common_weapon_break,

to all mission templates you want it in.

In my own module I just put it after every

common_battle_tab_press,

I think that add's it to pretty much all the fights in Singleplayer apart from custom battles.

[Peit]

nice work!

I am implementing this into my own mod as we speak

[Caba`drin]

This is a great idea--always seemed odd that a Shield could break, but weapons were invulnerable. Yet, a Tempered sword shattering with equal likelihood as a cracked one doesn't seem to have the same feel as the degrees of shield quality, etc. This brings me to my question...

Is there something to get what "imodbits_" the wielded weapon has? That way, if the weapon was "Balanced" or "Tempered" it could get damaged to normal...from normal to "Chipped" and from Chipped to "Cracked" and from "Cracked" to broken and taken away. The probability for the weapon to break could similarly change with the modifier--Balanced/Tempered/Masterwork items would be less likely to break than normal ones, and Cracked ones would be very likely to break.

Just a thought...I'll be looking around more still, but figured I'd put it out there to see if others knew if it were possible.

EDIT: I think messing with "troop_get_inventory_slot_modifier" something like this might be accomplished. I might start playing around with that...

[JethroKirby]

This is a great idea--always seemed odd that a Shield could break, but weapons were invulnerable. Yet, a Tempered sword shattering with equal likelihood as a cracked one doesn't seem to have the same feel as the degrees of shield quality, etc. This brings me to my question...

Is there something to get what "imodbits_" the wielded weapon has? That way, if the weapon was "Balanced" or "Tempered" it could get damaged to normal...from normal to "Chipped" and from Chipped to "Cracked" and from "Cracked" to broken and taken away. The probability for the weapon to break could similarly change with the modifier--Balanced/Tempered/Masterwork items would be less likely to break than normal ones, and Cracked ones would be very likely to break.

Just a thought...I'll be looking around more still, but figured I'd put it out there to see if others knew if it were possible.

I was wondering something similar, but instead of lowering them a level, they are just more resistant to breaking and more able to break another weapon. Is it also possible to handle weapons just as shields? As in, if it breaks in battle you have to find another weapon but you have enough time to repair the weapon between battles. Is this possible?

[Caba`drin]

I don't have WB installed on the computer I've access to for the rest of the week, but tried to think through this the best I could.

This is based on the following bit of code to capture the modifier for the currently equipped weapon, which I believe will do the trick, but please let me know if I totally missed something...

(click to show/hide)

           
            (try_for_range, ":i_slot", 0, 10),
                (troop_get_inventory_slot, ":item_id", "trp_player", ":i_slot"), 
                (eq, ":item_id", ":breakweapon"),
                (troop_get_inventory_slot_modifier, ":imod", "trp_player", ":i_slot"),
            (try_end)

The following code is marked with 'imod...' comments to denote my additions to Baron Conrad's original code.

(click to show/hide)

common_weapon_break =  (
         0.4, 0, 0,
       [

       #(player_get_agent_id, ":player_agent", ":player_no"),
       (get_player_agent_no, ":player_agent"),
      (agent_get_attack_action, ":playeraction", ":player_agent"), #returned values: free = 0, readying_attack = 1, releasing_attack = 2, completing_attack_after_hit = 3, attack_parried = 4, reloading = 5, after_release = 6, cancelling_attack = 7
        (try_begin),
             (eq,":playeraction",3),
          (agent_get_wielded_item,":breakweapon",":player_agent",0),
          (gt,":breakweapon",2),
            (item_get_type, ":weapontype", ":breakweapon"),
#--imod, get weapon imod
            (try_for_range, ":i_slot", 0, 10),
                (troop_get_inventory_slot, ":item_id", "trp_player", ":i_slot"),  #Find Item Slot with same item ID as Equipped Weapon
                (eq, ":item_id", ":breakweapon"),
                (troop_get_inventory_slot_modifier, ":imod", "trp_player", ":i_slot"),
            (try_end)
#--End Get imod
           (agent_get_horse,":playermounted",":player_agent"),
           (store_random_in_range,":weaponbreakchance",1,100),
          (try_begin),
            (ge,":playermounted",0),
      #      (display_message, "@Mounted."),
               (val_mul,":weaponbreakchance",104),
            (val_div,":weaponbreakchance",100),
            (eq,itp_type_polearm,":weapontype"),
            (val_mul,":weaponbreakchance",110),
            (val_div,":weaponbreakchance",100),
             (try_end),
         (try_begin),
             (eq,itp_type_polearm,":weapontype"),
      #       (display_message, "@Polearm"),
            (val_mul,":weaponbreakchance",102),
            (val_div,":weaponbreakchance",100),
          (try_end),
          (try_begin),
             (eq,itp_type_two_handed_wpn,":weapontype"),
      #       (display_message, "@2 hander"),
            (val_mul,":weaponbreakchance",101),
            (val_div,":weaponbreakchance",100),
         (try_end),
         (try_begin),
             (eq,itp_type_one_handed_wpn,":weapontype"),
      #       (display_message, "@1 hander"),
            (val_mul,":weaponbreakchance",1),
         (try_end),
#--imod Quality Modifier
    #Better than Average
        (try_begin),
            (eq, imodbit_masterwork, ":imod"),
            (val_mul,":weaponbreakchance",50),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_tempered, ":imod"),
            (val_mul,":weaponbreakchance",75),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_balanced, ":imod"),
            (val_mul,":weaponbreakchance",85),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_heavy, ":imod"),
            (val_mul,":weaponbreakchance",90),
            (val_div,":weaponbreakchance",100),
        (try_end),
    #Worse than Average
        (try_begin),
            (eq, imodbit_bent, ":imod"),
            (val_mul,":weaponbreakchance",110),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_rusty, ":imod"),
            (val_mul,":weaponbreakchance",125),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_chipped, ":imod"),
            (val_mul,":weaponbreakchance",150),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_cracked, ":imod"),
            (val_mul,":weaponbreakchance",200),
            (val_div,":weaponbreakchance",100),
        (try_end),
#--End imod Quality Modifier
        (try_begin),
            (assign, reg8, ":weaponbreakchance"),
      #      (display_message, "@{reg8}"),
            (ge,":weaponbreakchance",98),
            (agent_unequip_item,":player_agent",":breakweapon"),
            (play_sound,"snd_shield_broken",),
            (troop_remove_item, "trp_player", ":breakweapon"),
            (display_message, "@Hah! Your weapon broke."),
            (lt,":playermounted",0),
             (agent_set_animation, ":player_agent", "anim_strike_chest_front"),
            (try_end),

       (try_end),
      ], [])

And below, the script checks the imod to determine how drastically to damage the weapon. Better weapons just lose their improvements, normal weapons get chipped, lesser weapons break.

(click to show/hide)

common_weapon_break =  (
         0.4, 0, 0,
       [

       #(player_get_agent_id, ":player_agent", ":player_no"),
       (get_player_agent_no, ":player_agent"),
      (agent_get_attack_action, ":playeraction", ":player_agent"), #returned values: free = 0, readying_attack = 1, releasing_attack = 2, completing_attack_after_hit = 3, attack_parried = 4, reloading = 5, after_release = 6, cancelling_attack = 7
        (try_begin),
             (eq,":playeraction",3),
          (agent_get_wielded_item,":breakweapon",":player_agent",0),
          (gt,":breakweapon",2),
            (item_get_type, ":weapontype", ":breakweapon"),
#--imod, get weapon imod
            (try_for_range, ":i_slot", 0, 10),
                (troop_get_inventory_slot, ":item_id", "trp_player", ":i_slot"),  #Find Item Slot with same item ID as Equipped Weapon
                (eq, ":item_id", ":breakweapon"),
                (troop_get_inventory_slot_modifier, ":imod", "trp_player", ":i_slot"),
            (try_end)
#--End Get imod
           (agent_get_horse,":playermounted",":player_agent"),
           (store_random_in_range,":weaponbreakchance",1,100),
          (try_begin),
            (ge,":playermounted",0),
      #      (display_message, "@Mounted."),
               (val_mul,":weaponbreakchance",104),
            (val_div,":weaponbreakchance",100),
            (eq,itp_type_polearm,":weapontype"),
            (val_mul,":weaponbreakchance",110),
            (val_div,":weaponbreakchance",100),
             (try_end),
         (try_begin),
             (eq,itp_type_polearm,":weapontype"),
      #       (display_message, "@Polearm"),
            (val_mul,":weaponbreakchance",102),
            (val_div,":weaponbreakchance",100),
          (try_end),
          (try_begin),
             (eq,itp_type_two_handed_wpn,":weapontype"),
      #       (display_message, "@2 hander"),
            (val_mul,":weaponbreakchance",101),
            (val_div,":weaponbreakchance",100),
         (try_end),
         (try_begin),
             (eq,itp_type_one_handed_wpn,":weapontype"),
      #       (display_message, "@1 hander"),
            (val_mul,":weaponbreakchance",1),
         (try_end),
#--imod Quality Modifier
    #Better than Average
        (try_begin),
            (eq, imodbit_masterwork, ":imod"),
            (val_mul,":weaponbreakchance",50),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_tempered, ":imod"),
            (val_mul,":weaponbreakchance",75),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_balanced, ":imod"),
            (val_mul,":weaponbreakchance",85),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_heavy, ":imod"),
            (val_mul,":weaponbreakchance",90),
            (val_div,":weaponbreakchance",100),
        (try_end),
    #Worse than Average
        (try_begin),
            (eq, imodbit_bent, ":imod"),
            (val_mul,":weaponbreakchance",110),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_rusty, ":imod"),
            (val_mul,":weaponbreakchance",125),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_chipped, ":imod"),
            (val_mul,":weaponbreakchance",150),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_cracked, ":imod"),
            (val_mul,":weaponbreakchance",200),
            (val_div,":weaponbreakchance",100),
        (try_end),
#--End imod Quality Modifier
        (try_begin),
            (assign, reg8, ":weaponbreakchance"),
      #      (display_message, "@{reg8}"),
            (ge,":weaponbreakchance",98),
#--imod Weapon Damage
    #Better than Average
        (try_begin),
            (eq, imodbit_masterwork, ":imod"),
            (troop_set_inventory_slot_modifier, "trp_player", ":i_slot", imodbit_balanced),
        (else_try),
            (eq, imodbit_tempered, ":imod"),
            (troop_set_inventory_slot_modifier, "trp_player", ":i_slot", 0),
        (else_try),
            (eq, imodbit_balanced, ":imod"),
            (troop_set_inventory_slot_modifier, "trp_player", ":i_slot", 0),
        (else_try),
            (eq, imodbit_heavy, ":imod"),
            (troop_set_inventory_slot_modifier, "trp_player", ":i_slot", imodbit_chipped),
    #Worse than Average
        (else_try),
            (eq, imodbit_bent, ":imod"),
            (troop_set_inventory_slot_modifier, "trp_player", ":i_slot", imodbit_cracked),
    #Chipped, Cracked, Rusty weapons break
        (else_try),
            (this_or_next|eq, imodbit_rusty, ":imod"),
            (this_or_next|eq, imodbit_chipped, ":imod"),
            (eq, imodbit_cracked, ":imod"),
            (agent_unequip_item,":player_agent",":breakweapon"),
            (play_sound,"snd_shield_broken",),
            (troop_remove_item, "trp_player", ":breakweapon"),
            (display_message, "@Hah! Your weapon broke."),
            (lt,":playermounted",0),
             (agent_set_animation, ":player_agent", "anim_strike_chest_front"),
    #Normal Weapon gets Chipped
        (else_try),
            (troop_set_inventory_slot_modifier, "trp_player", ":i_slot", imodbit_chipped),
        (try_end),
#--End imod Weapon Damage
       (try_end),

       (try_end),
      ], [])

[Idibil]

great work here!

You have forgot a "," en try_end:

                (troop_get_inventory_slot_modifier, ":imod", "trp_player", ":i_slot"),
            (try_end),


I have try join your code with Cruger´s code, and look it work:

(click to show/hide)

#Brytenwalda -Baron Conrad script- armas se rompen
common_weapon_break =  (
         0.4, 0, 0,
       [], [
     
      #(player_get_agent_id, ":player_agent", ":player_no"),
#Cruger MODIFICATION BEGIN---------------------------------------------------------------------------
      # (get_player_agent_no, ":player_agent"),
     (try_for_agents, ":player_agent"),
#Cruger MODIFICATION END-----------------------------------------------------------------------------      (agent_get_attack_action, ":playeraction", ":player_agent"), #returned values: free = 0, readying_attack = 1, releasing_attack = 2, completing_attack_after_hit = 3, attack_parried = 4, reloading = 5, after_release = 6, cancelling_attack = 7
      (agent_get_attack_action, ":playeraction", ":player_agent"), #returned values: free = 0, readying_attack = 1, releasing_attack = 2, completing_attack_after_hit = 3, attack_parried = 4, reloading = 5, after_release = 6, cancelling_attack = 7
     (try_begin),
             (eq,":playeraction",3),
          (agent_get_wielded_item,":breakweapon",":player_agent",0),   
          (gt,":breakweapon",2),
            (item_get_type, ":weapontype", ":breakweapon"),
#--Cabadrin imod, get weapon imod
            (try_for_range, ":i_slot", 0, 10),
                (troop_get_inventory_slot, ":item_id", "trp_player", ":i_slot"),  #Find Item Slot with same item ID as Equipped Weapon
                (eq, ":item_id", ":breakweapon"),
                (troop_get_inventory_slot_modifier, ":imod", "trp_player", ":i_slot"),
            (try_end),
#--End Get imod
           (agent_get_horse,":playermounted",":player_agent"),
           (store_random_in_range,":weaponbreakchance",1,100),
          (try_begin),
            (ge,":playermounted",0),
      #      (display_message, "@Mounted."),
               (val_mul,":weaponbreakchance",84),   
            (val_div,":weaponbreakchance",100),
            (eq,itp_type_polearm,":weapontype"),
            (val_mul,":weaponbreakchance",90),
            (val_div,":weaponbreakchance",100),
             (try_end),
         (try_begin),           
             (eq,itp_type_polearm,":weapontype"),
      #       (display_message, "@Polearm"),
            (val_mul,":weaponbreakchance",82),
            (val_div,":weaponbreakchance",100),
          (try_end),
          (try_begin),           
             (eq,itp_type_two_handed_wpn,":weapontype"),
      #       (display_message, "@2 hander"),
            (val_mul,":weaponbreakchance",81),
            (val_div,":weaponbreakchance",100),
         (try_end),
         (try_begin),           
             (eq,itp_type_one_handed_wpn,":weapontype"),
      #       (display_message, "@1 hander"),
            (val_mul,":weaponbreakchance",1),
         (try_end),
#--Cabadrin imod Quality Modifier
    #Better than Average
        (try_begin),
            (eq, imodbit_masterwork, ":imod"),
            (val_mul,":weaponbreakchance",40),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_tempered, ":imod"),
            (val_mul,":weaponbreakchance",50),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_balanced, ":imod"),
            (val_mul,":weaponbreakchance",60),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_heavy, ":imod"),
            (val_mul,":weaponbreakchance",70),
            (val_div,":weaponbreakchance",100),
        (try_end),
    #Worse than Average
        (try_begin),
            (eq, imodbit_bent, ":imod"),
            (val_mul,":weaponbreakchance",80),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_rusty, ":imod"),
            (val_mul,":weaponbreakchance",90),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_chipped, ":imod"),
            (val_mul,":weaponbreakchance",105),
            (val_div,":weaponbreakchance",100),
        (try_end),
        (try_begin),
            (eq, imodbit_cracked, ":imod"),
            (val_mul,":weaponbreakchance",120),
            (val_div,":weaponbreakchance",100),
        (try_end),
#--End imod Quality Modifier
     (try_begin),   
            (assign, reg8, ":weaponbreakchance"),
      #      (display_message, "@{reg8}"),
            (ge,":weaponbreakchance",98),
#Cruger MODIFICATION BEGIN----------------------------------------------------------------------------
         (assign, ":num_agent_items", 0),
        (try_for_range, ":item", "itm_no_item", "itm_items_end"),
          (item_get_type, ":weapontype2", ":item"),
         (this_or_next|eq,itp_type_one_handed_wpn,":weapontype2"),
         (this_or_next|eq,itp_type_two_handed_wpn,":weapontype2"),
         (eq,itp_type_polearm,":weapontype2"),
         (try_begin),
         (agent_has_item_equipped,":player_agent",":item"),
         (val_add, ":num_agent_items", 1),
         (try_end),
         (try_end),
         (ge, ":num_agent_items", 2),
#Cruger MODIFICATION END------------------------------------------------------------------------------
            (agent_unequip_item,":player_agent",":breakweapon"),
#Cruger MODIFICATION BEGIN----------------------------------------------------------------------------
         (agent_get_troop_id,":troop", ":player_agent"),
          #  (troop_remove_item, "trp_player", ":breakweapon"),
         (try_begin),
         (get_player_agent_no,":player"),
         (eq, ":player_agent", ":player"),
         (play_sound,"snd_shield_broken",),
         (troop_remove_item, ":troop", ":breakweapon"),
            (display_message, "@Hah! Your weapon broke."),
         (try_end),
#Cruger MODIFICATION END------------------------------------------------------------------------------
            (lt,":playermounted",0),
             (agent_set_animation, ":player_agent", "anim_strike_chest_front"),
            (try_end),
     
       (try_end),
      (try_end),])
#brytenwalda armas se rompen acaba

[N0body]

Hey, for some reason I'm getting this syntax error:

(click to show/hide)

SyntaxError: invalid syntax
Traceback (most recent call last):
  File "process_global_variables_unused.py", line 3, in <module>
    from process_operations import *
  File "C:\Users\Admin\Desktop\OSPW - Native 1.127c Module_system\process_operat
ions.py", line 21, in <module>
    from module_mission_templates import *
  File "C:\Users\Admin\Desktop\OSPW - Native 1.127c Module_system\module_mission
_templates.py", line 1236
    common_weapon_break =  (
                                            ^

Any idea why or how I can fix it (I'm new to this stuff, sorry for being a Noob)

[Gaunt]

N0body, did you alter it in any way?


Caba ' drin, I did think about doing that, just never got round to it.

Glad that you guys are taking it even further!

[N0body]

N0body, did you alter it in any way?


Caba ' drin, I did think about doing that, just never got round to it.

Glad that you guys are taking it even further!

Nope, I did use Idibil's version of the code and I put it right after every common_battle_tab_press,
I'm going to try using the original now, and see if that works.

EDIT:
Managed to get it working, as I was a bit stupid and misread you post (Top of this page) and was putting the entire code after each common_battle_tab_press,
Sorry about that maybe I should make sure I read everything properly next time 
It still gets a 'minor' error though: ERROR: Usage of unassigned local variable: :playeraction
EDIT:
Ingame weapons don't seem to break, so I'm guessing that error is actually breaking the script?

[Idibil]

N0body, you try now, i had paste code that i am using in Brytenwalda.


Ah, and remmenber add: common_weapon_break, --->lead_charge and mission where you want weapon break.

[N0body]

N0body, you try now, i had paste code that i am using in Brytenwalda.


Ah, and remmenber add: common_weapon_break, --->lead_charge and mission where you want weapon break.

Thanks!  Looks like it has worked, no errors. Now to test it. 

Edit:
Hmmm.... I had 3 weapons on me (Ranging from cracked to tempered) and none of them broke - I was on horseback too.
I didn't notice and NPC's weapons breaking either 
Am I doing something wrong? I've put Idibil's version of the code before the very first multiplayer_server_check_belfry_movement and then put common_weapon_break, after every common_battle_tab_press,

[Gaunt]

Ibdil, I think your changes to the numbers may have been a little too drastic, that is why N0body never had his weapons break.

The way the system works right now is this:

First it picks a random number 1-100, the higher it is the more likely a weapon is to break.

Then it does the math things depending on weapon type, mounted, and modifers (what you added)

So in your code for a one handed weapon it multiplies by 81 and divides by 100, in other words, it multiplies by .81

Even if the random chance earlier in the  script is a 100 then the result is 100 * .81 = 81

At the end you notice that the weapon will only break if the result is 98 or higher.

Average one handed weapons would never break.


My numbers may have been to high to start with but when you lower them you need to lower them very slightly because if you lower them too much then they may never break.

[Idibil]

Yes, i am tested it. Brytenwalda betatester complained that the weapons are very easily broken, even in a first encounter. I am looking for equilibrate break, a sword could for generations, or break a particularly aggressive encounter.

I can change result of 98 to 95 

[N0body]

I'm wondering why the code isn't doing anything - I've had no errors either. 
I set the chance for each Imod bits to 135, the weapons still didn't break.
I even set the chance from 98 to 28, still nothing. I'm guessing this code doesn't like me 

[Gaunt]

I can change result of 98 to 95 

It will make more difference to change the multipliers.

Also I don't think having the multiplier smaller than the divider is a good idea unless the requirement is something that would make the weapon stronger, for example, masterwork.

To N0body, how many weapons did you have in your inventory, Crugers additions make it so your weapon only breaks if you have more than one weapon, I personally wouldn't use that.

Also, I hope you added

common_weapon_break,

to the mission templates you wanted it in.