Updated water travel! (BUGFIX #2)

[Earl of Swadia]

Hello,

I've just finished implementing the code but I got this error:

(click to show/hide)

Initializing...
Traceback (most recent call last):
  File "process_global_variables.py", line 5, in <module>
    from module_triggers import *
  File "C:\Program Files\Mount&Blade1.011\Module Systems\The Ranger's Apprentice
 Module System\module_triggers.py", line 58
    ]),
    ^
SyntaxError: invalid syntax
Exporting strings...
Exporting skills...
Exporting tracks...
Exporting animations...
Exporting meshes...
Exporting sounds...
Exporting skins...
Exporting map icons...
Creating new tag_uses.txt file...
Creating new quick_strings.txt file...
Exporting faction data...
Exporting item data...
Exporting scene data...
Exporting troops data
Exporting particle data...
Exporting scene props...
Exporting tableau materials data...
Exporting presentations...
Exporting party_template data...
Exporting parties
Exporting quest data...
Exporting scripts...
Exporting mission_template data...
Exporting game menus data...
exporting simple triggers...
Traceback (most recent call last):
  File "process_dialogs.py", line 5, in <module>
    from module_triggers import *
  File "C:\Program Files\Mount&Blade1.011\Module Systems\The Ranger's Apprentice
 Module System\module_triggers.py", line 58
    ]),
    ^
SyntaxError: invalid syntax
Checking global variable usages...

______________________________

Script processing has ended.
Press any key to exit. . .

And I went through to check the code and messed around with all the brackets a few times to no avail. Here's what my code looks like:

(click to show/hide)

  (0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),
      (neq,":terrain",rt_mountain_forest),], # rt_steppe is an example for the name of your new water terrain
   [(try_begin),
       (troop_get_inventory_slot, ":cur_horse", "trp_player", #horse slot
    (assign, ":new_icon", -1),
     (try_begin),
      (eq, "$g_player_icon_state", pis_normal),
      (try_begin),
        (ge, ":cur_horse", 0),
        (assign, ":new_icon", "icon_player_horseman"),
      (else_try),
        (assign, ":new_icon", "icon_player"),
      (try_end),
    (else_try),
      (eq, "$g_player_icon_state", pis_camping), # All of this is thanks to Lumos bein' generous, and not being as much of a lazy arse as I am
      (assign, ":new_icon", "icon_camp"),
    (try_end),
]),
 

    (0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),
      (neq,":terrain",rt_mountain_forest),], #Oh shi- ALL HAIL HYPNOTOAD
   [(party_set_icon,"p_main_party", "icon_player"),]),
 
 (0.1, 0, 0.0, [],
[(try_for_parties, ":cur_party"),
   (party_get_current_terrain, ":terrain", ":cur_party"),
   (eq, ":terrain", rt_mountain_forest),
  (party_get_template_id, ":cur_template", ":cur_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_hero_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_caravan_party"),
 (this_or_next|eq, ":cur_template", "pt_manhunters"),
 (this_or_next|eq, ":cur_template", "pt_village_farmers"),
 (this_or_next|eq, ":cur_template", "pt_deserters"),
 (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
   (party_set_icon, ":cur_party", "icon_ship"),
 (else_try),
   (neq,":terrain",rt_mountain_forest),
   (party_get_template_id, ":cur_template", ":cur_party"),
   (eq, ":cur_template", "pt_kingdom_hero_party"),
 (party_set_icon,":cur_party","icon_flagbearer_a"),
 (else_try),
 (eq, ":cur_template", "pt_kingdom_caravan_party"),
 (party_set_icon,":cur_party","icon_mule"),
 (else_try),
 (eq, ":cur_template", "pt_deserters"),
 (party_set_icon,":cur_party","icon_vaegir_knight"),
 (else_try),
 (eq, ":cur_template", "pt_manhunters"),
 (party_set_icon,":cur_party","icon_gray_knight"),
 (else_try),
  (eq, ":cur_template", "pt_village_farmers"),
 (party_set_icon,":cur_party","icon_peasant"),
 (else_try),
  (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
 (party_set_icon,":cur_party","icon_axeman"),
 (else_try),
 (eq, ":cur_template", "pt_cattle_herd"),
 (party_set_icon,":cur_party","icon_cattle"),
 (try_end),]),

Can anyone help please? I'm pretty sure it'll be a simple error

[Lord Leoric of Wercheg]

Alright, this might be wrong but did you add the stuff as the last entry in module_triggers? If so check the trigger before it. It might be missing a bracket at the end.

[Earl of Swadia]

It was the second trigger when I posted it. I've tried moving it to the top and that didn't work. Nor did moving it to the bottom. Thanks for the help though!

EDIT I: It worked out! I just added an additional bracket after the last try_end. Now, however, I'm getting:
rt_mountain_forest not defined.
But it is defined in header_terrain_types

EDIT II: And I figured that out too. I had to replace all the rt_mountain_forest instances only in module_triggers with 9, which was the numerical code for mountain_forest defined in terrain_types. Thanks for your help Lord Leoric! And Ruthven for this excellent compilation!

[Lord Leoric of Wercheg]

You're welcome mate

I accept cash or your hottest daughter.

[Armadyl]

WHERE CAN I FIND OR BUY SHIPS???

[Jezze]

WHERE CAN I FIND OR BUY SHIPS???

In Towns you can buy ships.

Has the rest of you also that sea pirates are spawning around several towns and how to fix this? Thanks in advance.

[mr wabbit]

The bug fix seems nice though I would rather not remove a terrian type myself and the effort of changing the map is more than I can be bothered with right now I will wait to see the Jubals new sea battles stripts myself and see when I want to go from there in the mean time nice work though and congrats to all that helped. hmm now to work on my undead troop tree which is looking a little on the large side but still can never have too many.

[Earl of Swadia]

Sorry to bother you all again I'm now getting this after replacing all the rt_mountain_forest with the number 9:

(click to show/hide)

Initializing...
Compiling all global variables...
Exporting strings...
Exporting skills...
Exporting tracks...
Exporting animations...
Exporting meshes...
Exporting sounds...
Exporting skins...
Exporting map icons...
Creating new tag_uses.txt file...
Creating new quick_strings.txt file...
Exporting faction data...
Exporting item data...
Exporting scene data...
Exporting troops data
Exporting particle data...
Exporting scene props...
Exporting tableau materials data...
Exporting presentations...
Exporting party_template data...
Exporting parties
Exporting quest data...
Exporting scripts...
Exporting mission_template data...
Exporting game menus data...
exporting simple triggers...
exporting triggers...
Traceback (most recent call last):
  File "process_dialogs.py", line 188, in <module>
    save_triggers(variables,variable_uses,triggers,tag_uses,quick_strings)
  File "process_dialogs.py", line 53, in save_triggers
    save_statement_block(file,0,1,trigger[trigger_consequences_pos], variable_li
st, variable_uses,tag_uses,quick_strings)
  File "C:\Program Files\Mount&Blade1.011\Module Systems\The Ranger's Apprentice
 Module System\process_operations.py", line 449, in save_statement_block
    save_statement(ofile,opcode,no_variables,statement,variable_list,variable_us
es,local_vars, local_var_uses,tag_uses,quick_strings)
  File "C:\Program Files\Mount&Blade1.011\Module Systems\The Ranger's Apprentice
 Module System\process_operations.py", line 401, in save_statement
    ofile.write("%d "%operand)
TypeError: not all arguments converted during string formatting
Checking global variable usages...
WARNING: Global variable never used: g_talk_troop_met
WARNING: Global variable never used: disable_local_histories
WARNING: Global variable never used: g_castle_left_to_player
WARNING: Global variable never used: g_player_follow_army_warnings
WARNING: Global variable never used: g_player_banner_granted
WARNING: Global variable never used: mercenary_service_next_pay_time
WARNING: Global variable never used: mercenary_service_next_renew_day
WARNING: Global variable never used: g_leave_town
WARNING: Global variable never used: caravan_escort_party_id
WARNING: Global variable never used: random_merchant_quest_no
WARNING: Global variable never used: g_player_entry_point
WARNING: Global variable never used: players_oath_renounced_begin_time
WARNING: Global variable never used: g_arena_training_kills
WARNING: Global variable never used: g_arena_training_won
WARNING: Global variable never used: g_encountered_party_type
WARNING: Global variable never used: spy_item_worn
WARNING: Global variable never used: spy_quest_troop
WARNING: Global variable never used: npc_grievance_string
WARNING: Global variable never used: npc_grievance_slot
WARNING: Global variable never used: npc_map_talk_context
WARNING: Global variable never used: log_comment_relation_change

______________________________

Script processing has ended.
Press any key to exit. . .

The red bit is most likely the problem. It seems to have messed up process_operations, which I have never even opened. I've been reading through the thread and the fix by using numbers instead of rt... seems to have worked before. Did anyone else get this error? Or does anoyone know how to fix this?

[Ruthven]

Hmm, can you post the code? (Just the trigger)

[Earl of Swadia]

(click to show/hide)

###Sea Battles Begin###
  (0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),
      (neq,":terrain", 9),], # rt_steppe is an example for the name of your new water terrain
   [(try_begin),
       (troop_get_inventory_slot, ":cur_horse", "trp_player", #horse slot
    (assign, ":new_icon", -1),
     (try_begin),
      (eq, "$g_player_icon_state", pis_normal),
      (try_begin),
        (ge, ":cur_horse", 0),
        (assign, ":new_icon", "icon_player_horseman"),
      (else_try),
        (assign, ":new_icon", "icon_player"),
      (try_end),
    (else_try),
      (eq, "$g_player_icon_state", pis_camping), # All of this is thanks to Lumos bein' generous, and not being as much of a lazy arse as I am
      (assign, ":new_icon", "icon_camp"),
    (try_end)),
  ]),
 

    (0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),
      (neq,":terrain", 9),], #Oh shi- ALL HAIL HYPNOTOAD
   [(party_set_icon,"p_main_party", "icon_player"),]),
 
 (0.1, 0, 0.0, [],
[(try_for_parties, ":cur_party"),
   (party_get_current_terrain, ":terrain", ":cur_party"),
   (eq, ":terrain", 9),
  (party_get_template_id, ":cur_template", ":cur_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_hero_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_caravan_party"),
 (this_or_next|eq, ":cur_template", "pt_manhunters"),
 (this_or_next|eq, ":cur_template", "pt_village_farmers"),
 (this_or_next|eq, ":cur_template", "pt_deserters"),
 (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
   (party_set_icon, ":cur_party", "icon_ship"),
 (else_try),
   (neq,":terrain",9),
   (party_get_template_id, ":cur_template", ":cur_party"),
   (eq, ":cur_template", "pt_kingdom_hero_party"),
 (party_set_icon,":cur_party","icon_flagbearer_a"),
 (else_try),
 (eq, ":cur_template", "pt_kingdom_caravan_party"),
 (party_set_icon,":cur_party","icon_mule"),
 (else_try),
 (eq, ":cur_template", "pt_deserters"),
 (party_set_icon,":cur_party","icon_vaegir_knight"),
 (else_try),
 (eq, ":cur_template", "pt_manhunters"),
 (party_set_icon,":cur_party","icon_gray_knight"),
 (else_try),
  (eq, ":cur_template", "pt_village_farmers"),
 (party_set_icon,":cur_party","icon_peasant"),
 (else_try),
  (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
 (party_set_icon,":cur_party","icon_axeman"),
 (else_try),
 (eq, ":cur_template", "pt_cattle_herd"),
 (party_set_icon,":cur_party","icon_cattle"),
 (try_end),]),
###Sea Battles End###

[thrakkemarn]

For reference, I had to modify the code a bit to make it work, so here is my working code:

(click to show/hide)

Code: [Select]

## SEA BATTLES BEGIN
(0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),(assign,reg1,":terrain")], # rt_steppe is an example for the name of your new water terrain
   [(try_begin),
       (troop_get_inventory_slot, ":cur_horse", "trp_player", 8), #horse slot
    (assign, ":new_icon", -1),
    (try_begin),
      (eq,reg1,5),
      (assign, ":new_icon", "icon_ship"),
     #(display_message,"@water"),
     (else_try),
      (eq, "$g_player_icon_state", pis_normal),
      (try_begin),
        (ge, ":cur_horse", 0),
        (assign, ":new_icon", "icon_player_horseman"),
        #(display_message,"@no water, horse"),
      (else_try),
        (assign, ":new_icon", "icon_player"),
        #(display_message,"@no water, no horse"),
      (try_end),
    (else_try),
      (eq, "$g_player_icon_state", pis_camping), # All of this is thanks to Lumos bein' generous, and not being as much of a lazy arse as I am
      (assign, ":new_icon", "icon_camp"),
    (try_end),
    (party_set_icon,"p_main_party", ":new_icon"),
]),
 

#    (0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),
 #     (neq,":terrain",5),], #Oh shi- ALL HAIL HYPNOTOAD
 #  [(party_set_icon,"p_main_party", "icon_player"),
 #  (display_message,"@Not water"),
  # ]),
 
 (0.1, 0, 0.0, [],
[(try_for_parties, ":cur_party"),
   (party_get_current_terrain, ":terrain", ":cur_party"),
   (eq, ":terrain", 5),
  (party_get_template_id, ":cur_template", ":cur_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_hero_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_caravan_party"),
 (this_or_next|eq, ":cur_template", "pt_manhunters"),
 (this_or_next|eq, ":cur_template", "pt_village_farmers"),
 (this_or_next|eq, ":cur_template", "pt_deserters"),
 (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
   (party_set_icon, ":cur_party", "icon_ship"),
 (else_try),
   (neq,":terrain",5),
   (party_get_template_id, ":cur_template", ":cur_party"),
   (eq, ":cur_template", "pt_kingdom_hero_party"),
 (party_set_icon,":cur_party","icon_flagbearer_a"),
 (else_try),
 (eq, ":cur_template", "pt_kingdom_caravan_party"),
 (party_set_icon,":cur_party","icon_mule"),
 (else_try),
 (eq, ":cur_template", "pt_deserters"),
 (party_set_icon,":cur_party","icon_vaegir_knight"),
 (else_try),
 (eq, ":cur_template", "pt_manhunters"),
 (party_set_icon,":cur_party","icon_gray_knight"),
 (else_try),
  (eq, ":cur_template", "pt_village_farmers"),
 (party_set_icon,":cur_party","icon_peasant"),
 (else_try),
  (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
 (party_set_icon,":cur_party","icon_axeman"),
 (else_try),
 (eq, ":cur_template", "pt_cattle_herd"),
 (party_set_icon,":cur_party","icon_cattle"),
 (try_end),]),
## SEA BATTLES END

[Earl of Swadia]

For reference, I had to modify the code a bit to make it work, so here is my working code:

(click to show/hide)

Code: [Select]

## SEA BATTLES BEGIN
(0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),(assign,reg1,":terrain")], # rt_steppe is an example for the name of your new water terrain
   [(try_begin),
       (troop_get_inventory_slot, ":cur_horse", "trp_player", 8), #horse slot
    (assign, ":new_icon", -1),
    (try_begin),
      (eq,reg1,5),
      (assign, ":new_icon", "icon_ship"),
     #(display_message,"@water"),
     (else_try),
      (eq, "$g_player_icon_state", pis_normal),
      (try_begin),
        (ge, ":cur_horse", 0),
        (assign, ":new_icon", "icon_player_horseman"),
        #(display_message,"@no water, horse"),
      (else_try),
        (assign, ":new_icon", "icon_player"),
        #(display_message,"@no water, no horse"),
      (try_end),
    (else_try),
      (eq, "$g_player_icon_state", pis_camping), # All of this is thanks to Lumos bein' generous, and not being as much of a lazy arse as I am
      (assign, ":new_icon", "icon_camp"),
    (try_end),
    (party_set_icon,"p_main_party", ":new_icon"),
]),
 

#    (0.1, 0, 0, [(party_get_current_terrain,":terrain","p_main_party"),
 #     (neq,":terrain",5),], #Oh shi- ALL HAIL HYPNOTOAD
 #  [(party_set_icon,"p_main_party", "icon_player"),
 #  (display_message,"@Not water"),
  # ]),
 
 (0.1, 0, 0.0, [],
[(try_for_parties, ":cur_party"),
   (party_get_current_terrain, ":terrain", ":cur_party"),
   (eq, ":terrain", 5),
  (party_get_template_id, ":cur_template", ":cur_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_hero_party"),
 (this_or_next|eq, ":cur_template", "pt_kingdom_caravan_party"),
 (this_or_next|eq, ":cur_template", "pt_manhunters"),
 (this_or_next|eq, ":cur_template", "pt_village_farmers"),
 (this_or_next|eq, ":cur_template", "pt_deserters"),
 (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
   (party_set_icon, ":cur_party", "icon_ship"),
 (else_try),
   (neq,":terrain",5),
   (party_get_template_id, ":cur_template", ":cur_party"),
   (eq, ":cur_template", "pt_kingdom_hero_party"),
 (party_set_icon,":cur_party","icon_flagbearer_a"),
 (else_try),
 (eq, ":cur_template", "pt_kingdom_caravan_party"),
 (party_set_icon,":cur_party","icon_mule"),
 (else_try),
 (eq, ":cur_template", "pt_deserters"),
 (party_set_icon,":cur_party","icon_vaegir_knight"),
 (else_try),
 (eq, ":cur_template", "pt_manhunters"),
 (party_set_icon,":cur_party","icon_gray_knight"),
 (else_try),
  (eq, ":cur_template", "pt_village_farmers"),
 (party_set_icon,":cur_party","icon_peasant"),
 (else_try),
  (this_or_next|eq, ":cur_template", "pt_looters"),
 (this_or_next|eq, ":cur_template", "pt_forest_bandits"),
 (this_or_next|eq, ":cur_template", "pt_steppe_bandits"),
 (this_or_next|eq, ":cur_template", "pt_mountain_bandits"),
 (eq, ":cur_template", "pt_sea_raiders"),
 (party_set_icon,":cur_party","icon_axeman"),
 (else_try),
 (eq, ":cur_template", "pt_cattle_herd"),
 (party_set_icon,":cur_party","icon_cattle"),
 (try_end),]),
## SEA BATTLES END

Many thanks for that thrakkemarn! It worked perfectly after some minor adjustments

[Ruthven]

Hrmm.  Not sure what went wrong, but oh well, thanks, I'll reference it in the first post in case anyone else is having troubles.

[thrakkemarn]

Glad to be of service. I have no idea why the original code wasn't working, it seemed to be correct. One of those bizarre code mysteries...

[Nikephoros]

What does this basically change from mirathei's code?

If i got it correctly, once you walk into the steppes (or a terrain of your choice) your party becomes a "ship" and you start fighting (improved, even if i don't specifically know how) naval battles?

Sorry, i'm still no expert in reading codes.